Trim the input of operationId filter in OpenAPINormalizer (#20186)#20189
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Nov 30, 2024
danielalmqvist:master
Merged
Trim the input of operationId filter in OpenAPINormalizer (#20186)#20189wing328 merged 1 commit intoOpenAPITools:masterfrom danielalmqvist:master
wing328 merged 1 commit intoOpenAPITools:masterfrom
danielalmqvist:master
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Contributor
Author
|
thank you, updated the commiter now |
Member
|
thanks for the PR, which has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20186
Additional test added to test the trim-functionality.
Generation Details
FILTER=operationId: addPet| getPetById
Steps to reproduce
Use openapiNormalizer and FILTER and set them on separate lines.
Expected the operationIdFilters to contain addPet and getPetById.
Actually the operationIdFilters contains addPet and \n\t\t\t\t\t\t\tgetPetById
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)